Fix doc collision for lib/bin with a dash in the inferred name. by ehuss · Pull...
source link: https://github.com/rust-lang/cargo/pull/13640
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Contributor
This fixes an issue where cargo doc would report a collision if the project has a - in the name, and both a lib and bin. As a consequence of the change in #12783, the target name for the library no longer has a -. The code that checks for the lib/bin doc collision was only checking if the target names were equal, which is no longer the case after #12783. The solution here is to use the crate_name and not the target name, which has the appropriate _ translation done. This is the more correct method to use, even before #12783, because rustdoc uses crate names, not target names (and thus even documenting bins have their filenames converted to underscores).
Fixes #13628
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK