2

feat: Report some dependency changes on any command by epage · Pull Request #135...

 1 month ago
source link: https://github.com/rust-lang/cargo/pull/13561
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

feat: Report some dependency changes on any command #13561

Merged

Conversation

Contributor

What does this PR try to resolve?

The goal is to help users be informed when they are held back by either MSRV or semver.

Fixes #13539

How should we test and review this PR?

Additional information

Collaborator

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot

added A-lockfile Area: Cargo.lock issues Command-generate-lockfile

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Mar 8, 2024

epage

changed the title feat: Report some dependency changes on any command

WIP: feat: Report some dependency changes on any command

Mar 8, 2024

Contributor

Author

Test failures will show what the proposed output is

Collaborator

☔ The latest upstream changes (presumably #13564) made this pull request unmergeable. Please resolve the merge conflicts.

epage

changed the title WIP: feat: Report some dependency changes on any command

feat: Report some dependency changes on any command

Mar 19, 2024

epage

marked this pull request as ready for review

March 19, 2024 01:09

Member

@weihanglo weihanglo

left a comment

Went through every file changes 💀. Thanks!

@@ -417,7 +417,7 @@ fn frequency() {

.env("CARGO_GC_AUTO_FREQUENCY", "1 day")

.masquerade_as_nightly_cargo(&["gc"])

.run();

assert_eq!(get_index_names().len(), 0);

assert_eq!(get_index_names().len(), 1);

Guess this is a consequence of cargo querying the latest versions for displaying lockfile changes after the build, while auto-gc was run ahead of the build.

Seems like a waste of energy but in real world that rarely happens and would be fine 🙆🏾‍♂️.

Member

This PR includes a UI change that prints a Locking status when any command modifies the lockfile, along with showing the latest version if any updated dependency in use is behind (or outdated, though it is way too strong a word).

The Cargo team has discussed and considered it as a two-way-door change so I'm gonna merge this.

@bors r+

Collaborator

📌 Commit 4ab2797 has been approved by weihanglo

It is now in the queue for this repository.

bors

removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label

Mar 20, 2024

bors

added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label

Mar 20, 2024

Collaborator

⌛ Testing commit 4ab2797 with merge 266a5ef...

Collaborator

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 266a5ef to master...

bors

merged commit 266a5ef into

rust-lang:master

Mar 20, 2024

21 checks passed

epage

deleted the msrv-report branch

March 20, 2024 14:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

weihanglo

weihanglo approved these changes
Labels
A-lockfile Area: Cargo.lock issues A-testing-cargo-itself Area: cargo's tests Command-generate-lockfile S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Report newly held back dependencies on all commands

4 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK