2

Fix publish script due to crates.io CDN change by ehuss · Pull Request #13614 ·...

 1 month ago
source link: https://github.com/rust-lang/cargo/pull/13614
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Fix publish script due to crates.io CDN change #13614

Conversation

Contributor

Now that crates.io goes directly to the CDN, this has changed the HTTP response code when a crate is not found (from 404 to 403). This updates the publish script to handle more error codes to assume something isn't published. This also updates it to go directly to the endpoint instead of through the crates.io redirect.

Collaborator

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot

added A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Mar 21, 2024

Member

@weihanglo weihanglo

left a comment

Thanks.

Could we add some print for each crate to help future debugging?

Member

r=weihanglo whenever you want to proceed or add some print.

Contributor

Author

Good idea, I added a print.

@bors r=weihanglo

Collaborator

📌 Commit 97d896f has been approved by weihanglo

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Mar 21, 2024

Collaborator

⌛ Testing commit 97d896f with merge c3ad639...

Collaborator

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing c3ad639 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

weihanglo

weihanglo approved these changes
Labels
A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

None yet

4 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK