I don't think this is enough to close #12366, I'd like to make sure there isn't some bad assumption in the lint implementation. As a follow-up, I'd probably look for other calls to match_trait_method and see what can be replaced with sym!

This (unused_io) is the only lint that relies on match_trait_method. Maybe there's an alternative and we could remove the function completely?

Removing this function if it doesn't do what's expected of it seems like the way forward indeed.

As for the change, looks good to me. 👍

Removing it most likely requires adding a diag symbols for tokio (is that even possible?). Maybe there's an alternative?

If it's deprecated with only one use remaining it could be moved out of clippy utils

Should I move it to unused_io_amount then and remove it from the following?

book/src/development/trait_checking.md
tests/ui-internal/unnecessary_def_path.*
clippy_utils/src/lib.rs
clippy_lints/src/utils/internal_lints/unnecessary_def_path.rs

Ah it's documented as a fallback. Could leave it, I don't feel too strongly either way

This doesn't need to change. #12366 is a rustc issue since lints shouldn't have been running after an error.

As is it can still fail, but I don't feel particularly strongly about this.

If it's already documented in the book as a fallback, I would keep it, just another option for contributors.

Also, adding a diagnostic item for tokio (or any external crate) would not be a wise decision. Philipp talked against it for future lints (we have some lints based on futures I think, and those were a mistake), so yeah :/

@bors r+

📌 Commit 94fe2fa has been approved by blyxyas

It is now in the queue for this repository.

⌛ Testing commit 94fe2fa with merge d8d0018...

💔 Test failed - checks-action_test

Changelog failure.
@bors r+

💡 This pull request was already approved, no need to approve it again.

• This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

📌 Commit 94fe2fa has been approved by blyxyas

It is now in the queue for this repository.

⌛ Testing commit 94fe2fa with merge 805ef35...