5

Fix incorrect mutable suggestion information for binding in ref pattern. by sure...

 4 weeks ago
source link: https://github.com/rust-lang/rust/pull/122677
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Fix incorrect mutable suggestion information for binding in ref pattern. #122677

Conversation

Contributor

For ref pattern in func param, the mutability suggestion has to apply to the binding.

For example: fn foo(&x: &i32) -> fn foo(&(mut x): &i32)

fixes #122415

Collaborator

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot

added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Mar 18, 2024

@@ -3466,7 +3466,6 @@

"ui/pattern/issue-106552.rs",

"ui/pattern/issue-106862.rs",

"ui/pattern/issue-110508.rs",

"ui/pattern/issue-114896.rs",

Contributor

nice, thanks for that :)

Comment on lines

751 to 754

body.params.iter().any(|param| {

if let hir::Pat { kind: hir::PatKind::Ref(_, _), span, .. } = param.pat

&& *span == pat_span

{

Contributor

Is it possible ot extend the BindingFinder to look into function parameters as well instead of special-casing here?

Contributor

Author

Is it possible ot extend the BindingFinder to look into function parameters as well instead of special-casing here?

It is indeed better to query through BindingFinder.
Done, thank you

Contributor

Looks good, thank you!

@bors r+

Contributor

📌 Commit 19f72df has been approved by Nadrieril

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Mar 19, 2024

bors

merged commit 17386b8 into

rust-lang:master

Mar 19, 2024

11 checks passed

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Mar 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Nadrieril

Awaiting requested review from Nadrieril
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

Compiler incorrectly suggests &mut x instead of &(mut x) in a pattern for Copy types.

4 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK