Github match_single_binding: Fix invalid suggestion when match scrutinee has sid...
source link: https://github.com/rust-lang/rust-clippy/pull/7095
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
fixes #7094
changelog: match_single_binding: Fix invalid suggestion when match scrutinee has side effects
Expr::can_have_side_effects is used to determine the scrutinee has side effects, while this method is a little bit conservative for our use case. But I'd like to use it to avoid reimplementation of the method and too much heuristics. If you think this is problematic, then I'll implement a custom visitor to address it.
Recommend
-
88
A new version of Google Contacts came out yesterday, but it unfortunately doesn't seem to solve the recent issue with contact syncing that some Oreo users... by Cody Toombs in APK Teardown, Applications, Downloads, News
-
58
-
5
New issue manual_unwrap_or: fix invalid code suggestion, due to macro expansion #7136
-
5
Copy link Collaborator rust-highfive
-
0
Copy link Collaborator
-
1
Copy link Collaborator
-
5
TechMatch launches a dating app for single parentsPublished Mon, Mar 21 20228:53 AM EDTUpdated 2 Hours Ago
-
2
org.apache.ibatis.binding.BindingException: Invalid bound statement (not found): cs.zsl.mapper.Syste 精选 原创
-
4
Conversation Contributor This P...
-
5
Fix incorrect mutable suggestion information for binding in ref pattern. #122677 ...
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK