4

Track run-make-support lib in common inputs stamp by jieyouxu · Pull Request #12...

 1 month ago
source link: https://github.com/rust-lang/rust/pull/122962
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Conversation

Contributor

So that when the support library gets modified, run-make tests are forced to re-run instead of being still ignored as if nothing changed.

Fixes #122961.

Collaborator

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot

added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Mar 23, 2024

Member

@bors r+ rollup

Contributor

📌 Commit 894555f has been approved by onur-ozkan

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Mar 24, 2024

bors

merged commit 5281fe2 into

rust-lang:master

Mar 24, 2024

11 checks passed

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Mar 24, 2024

jieyouxu

deleted the stamp-rmake-support-lib branch

March 24, 2024 18:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

onur-ozkan

onur-ozkan approved these changes
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

run-make tests not forcibly re-run if the run-make-support library is modified

5 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK