1

many-seeds: propagate failure properly by RalfJung · Pull Request #3406 · rust-l...

 1 month ago
source link: https://github.com/rust-lang/miri/pull/3406
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

many-seeds: propagate failure properly #3406

Conversation

Member

Fixes #3405.

Member

Author

Okay so now it indeed does fail on Windows. But in a strange way:

 Error: io error when running command `./miri run tests/many-seeds/scoped-thread-leak.rs`: %1 is not a valid Win32 application. (os error 193)

@ChrisDenton can Command not spawn scripts on Windows? Would it work to run the batch script instead of the bash script?

Contributor

On Windows you can only reliably run exe files.

rust-lang/rust#94743 has some more details (though ultimately adding support for scripts was not popular)

Member

Author

Then either we can get bash to launch the script for us or we'll have to disable the test on Windows. I don't want to duplicate the logic from './miri' that computes where the binary is.

Member

Author

This might work...
@bors r+

Collaborator

📌 Commit 5759160 has been approved by RalfJung

It is now in the queue for this repository.

Collaborator

⌛ Testing commit 5759160 with merge 344ea00...

Collaborator

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 344ea00 to master...

bors

merged commit 344ea00 into

rust-lang:master

Mar 24, 2024

8 checks passed

RalfJung

deleted the many-seeds branch

March 24, 2024 18:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels
None yet
Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Are our many-seeds tests failing on Windows?

3 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK