2

fix: Warn on -Zlints by Muscraft · Pull Request #13632 · rust-lang/cargo · GitHu...

 1 month ago
source link: https://github.com/rust-lang/cargo/pull/13632
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

fix: Warn on -Zlints #13632

Conversation

Contributor

When the [lints] table was stabilized in #12648, it appears that making -Zlints into a warning when specified was missed, this PR fixes that.

Collaborator

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot

added A-unstable Area: nightly unstable support S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Mar 23, 2024

Contributor

@ehuss ehuss

left a comment

I think the field also needs to be removed from the unstable_cli_options.

Muscraft reacted with thumbs up emoji

src/cargo/core/features.rs

Outdated Show resolved

Contributor

Thanks!

@bors r+

Collaborator

📌 Commit 0e3503e has been approved by ehuss

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Mar 23, 2024

Collaborator

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?Error message

bors

added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.

and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Mar 23, 2024

Collaborator

☔ The latest upstream changes (presumably #13621) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

@bors r+

Collaborator

📌 Commit c006a30 has been approved by ehuss

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.

labels

Mar 23, 2024

Collaborator

⌛ Testing commit c006a30 with merge 77506e5...

Collaborator

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 77506e5 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ehuss

ehuss left review comments
Assignees

ehuss

Labels
A-unstable Area: nightly unstable support S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

None yet

4 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK