fix: set the right postfix snippets competion source range by mrnossiom · Pull R...
source link: https://github.com/rust-lang/rust-analyzer/pull/17000
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
fix: set the right postfix snippets competion source range #17000
Conversation
added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label
Member
|
Thanks! |
Collaborator
|
☀️ Test successful - checks-actions |
Contributor
|
thanks for working on this! I just wanted to say that this doesn't just fix the preview (which is just a visual thing) but also multicursor completions. Additional text edits can't be mapped to multiple cursor (since they aren't associated with the cursor. The spec actually considers this use case. You don't want to repeat imports for each cursor for example). I see that RA does this as a workaround for LSP only allowing a single edit to each completion item. I think that generally makes sense for associated edits like imports but I can't think of a practical case where multiple edits would be associated with each cursor. I suspect the RA completion edit could be brought closer to the lsp completion edit and avoid impedance mismatches like this bug |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
No one assigned
None yet
No milestone
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK