3

do not ICE in `fn forced_ambiguity` if we get an error by lcnr · Pull Request #1...

 3 weeks ago
source link: https://github.com/rust-lang/rust/pull/123477
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

do not ICE in fn forced_ambiguity if we get an error #123477

Conversation

Contributor

see the comment. currently causing an ICE in typenum which we've been unable to minimize.

r? @compiler-errors

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative

labels

Apr 4, 2024

Collaborator

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@bors r+ rollup

I would like to revisit this before, e.g., stabilizing -Znext-solver=full, but I agree+understand that this is ridiculously difficult to investigate atm.

Contributor

📌 Commit 9444ca3 has been approved by compiler-errors

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Apr 4, 2024

bors

merged commit e01d3e0 into

rust-lang:master

Apr 5, 2024

11 checks passed

rustbot

added this to the 1.79.0 milestone

Apr 5, 2024

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Apr 5, 2024

lcnr

deleted the forced_ambig-no-ice branch

April 5, 2024 08:29

Oneirical

added a commit to Oneirical/rust that referenced this pull request

Apr 6, 2024

Member

We can probably reduce it a bit more, but it's not bad for typenum?

There you go

    
     
     

  
   
     

       
      = 

    

     
     

      = 


     
      
        
    

    

         

     
         


         

      
       <   >


          

   
     


   

      
    <   > 
        

    

(I didn't know how old the ICE was, but it's recent, from #122687)

you're a wizard @lqd

lqd reacted with laugh emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative
Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

None yet

5 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK