Match ergonomics: implement "`&`pat everywhere" by Jules-Bertholet...
source link: https://github.com/rust-lang/rust/pull/123311
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Contributor
Implements the eat-two-layers (feature gate and_pat_everywhere, all editions) and the eat-one-layer (feature gate (EDIT: will be done in later PR) semantics.and_eat_one_layer_2024, edition 2024 only, takes priority on that edition when both feature gates are active)
cc #123076
r? @Nadrieril
@rustbot label A-patterns A-edition-2024
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Collaborator
|
Some changes occurred in match checking cc @Nadrieril |
Contributor
|
FYI by "compatible" mutability I just meant that it made sense to me if Nit: could we call them |
I've started reviewing the first commit. Could you split of the second commit to a different PR please? Overall looks good, but I want to take a bit longer to think if we can do something clearer for AdjustMode.
added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Contributor
|
🚀 @bors r+ |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK