3

std::thread: refine available_parallelism for solaris/illumos. by devnexen · Pul...

 4 weeks ago
source link: https://github.com/rust-lang/rust/pull/122992
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Conversation

Contributor

Rather than the system-wide available cpus fallback solution, we fetch the cpus bound to the current process.

Collaborator

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot

added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

labels

Mar 24, 2024

Member

@bors r+

Contributor

📌 Commit 4b84df9 has been approved by Amanieu

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Mar 24, 2024

Member

@the8472 the8472

left a comment

Am I missing something? ISTM that the new block would never be reached because the first block in the cfg_if already covers solaris and illumos. Have you checked with strace or whatever equivalent they have?

devnexen reacted with thumbs up emoji

Member

@bors r+

Contributor

📌 Commit 1871ea5 has been approved by Amanieu

It is now in the queue for this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

the8472

the8472 left review comments
Assignees

Amanieu

Labels
O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

None yet

5 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK