Correct version for incompatible_msrv by Manishearth · Pull Request #12522 · rus...
source link: https://github.com/rust-lang/rust-clippy/pull/12522
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Correct version for incompatible_msrv #12522
Merged
Conversation
Member
added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label
I explicitly checked the changelog but the entry was generated after I suggested it go into the blog post. In Cargo, we generate the beta changelog entry when branched from master which would have made it available and this would have been caught. |
Member
This was the correct version when the lint PR was created and a great example, why nightly lints would be awesome. I usually update the version attributes when I write the changelog for that version. But this sadly creates a desync. I'd correct this version, when I write the changelog for 1.78. |
FWIW, rust-lang/rust has a magic string and script that we bump version numbers for during nightly -> beta promotion (when the version number becomes fixed). See https://github.com/rust-lang/rust/blob/master/src/tools/replace-version-placeholder/src/main.rs for the script. If clippy wanted to, you could likely rely on us running that script and picking up the version numbers in a subsequent subtree sync? |
Member
That's something I haven't considered before. Thank you for the idea, I'll investigate it, when I find the time :D |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
No milestone
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK