0

Correct version for incompatible_msrv by Manishearth · Pull Request #12522 · rus...

 1 month ago
source link: https://github.com/rust-lang/rust-clippy/pull/12522
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Correct version for incompatible_msrv #12522

Merged

bors merged 1 commit into

master

from

Manishearth-patch-1

Mar 22, 2024

Conversation

Member

Unsure what happened here

Probably what caused rust-lang/blog.rust-lang.org#1277

changelog: none

Collaborator

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot

added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label

Mar 21, 2024

Probably what caused rust-lang/blog.rust-lang.org#1277

I explicitly checked the changelog but the entry was generated after I suggested it go into the blog post. In Cargo, we generate the beta changelog entry when branched from master which would have made it available and this would have been caught.

Member

Unsure what happened here

This was the correct version when the lint PR was created and a great example, why nightly lints would be awesome. I usually update the version attributes when I write the changelog for that version. But this sadly creates a desync. I'd correct this version, when I write the changelog for 1.78.

FWIW, rust-lang/rust has a magic string and script that we bump version numbers for during nightly -> beta promotion (when the version number becomes fixed). See https://github.com/rust-lang/rust/blob/master/src/tools/replace-version-placeholder/src/main.rs for the script.

If clippy wanted to, you could likely rely on us running that script and picking up the version numbers in a subsequent subtree sync?

Member

That's something I haven't considered before. Thank you for the idea, I'll investigate it, when I find the time :D

Manishearth reacted with heart emoji

Member

Either way, I think we can merge this for now :). Thank you for the update!

r? @xFrednet

@bors r+

Collaborator

📌 Commit 87b9352 has been approved by xFrednet

It is now in the queue for this repository.

Collaborator

⌛ Testing commit 87b9352 with merge fc053c3...

bors

merged commit fc053c3 into

master

Mar 22, 2024

6 checks passed

y21

deleted the Manishearth-patch-1 branch

March 25, 2024 10:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

xFrednet

xFrednet approved these changes
Assignees

xFrednet

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

None yet

7 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK