Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()` by gurry · Pull Req...
source link: https://github.com/rust-lang/rust/pull/122370
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Contributor
Instead of running the WF check on the AnonConst itself we run it on the ty of the generic param of which the AnonConst is the default value.
Fixes #122199
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use r? to explicitly pick a reviewer |
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Member
|
@bors r+ |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Member
|
I think this needs a rebase |
This comment has been minimized.
Contributor
|
@bors r- |
added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Contributor
|
PR is incompatible with #122513 It looks like you can "just" replace the code with |
Contributor
Author
|
Rebase done. @rustbot label -S-waiting-on-author +S-waiting-on-review |
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Contributor
|
This looks exactly the same so, @bors r=davidtwco |
removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label
added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label
Contributor
|
💥 Test timed out |
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Contributor
|
@bors retry |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
|
Assuming that was spurious based on only one job hanging. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Successfully merging this pull request may close these issues.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK