2

fix: Fix projects depending on `rustc_private` hanging by Veykril · Pull Request...

 1 month ago
source link: https://github.com/rust-lang/rust-analyzer/pull/16911
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

fix: Fix projects depending on rustc_private hanging #16911

Conversation

Member

If loading the root fails, we'll hang up in this loop as we never inserted the entry that asserts we already visited a package. This fixes that
Fixes #16902

alibektas, lukas-code, and WaffleLapkin reacted with hooray emoji

rustbot

added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label

Mar 21, 2024

Member

Author

@bors r+

Collaborator

📌 Commit 2ad14b8 has been approved by Veykril

It is now in the queue for this repository.

Collaborator

⌛ Testing commit 2ad14b8 with merge a3d9625...

Collaborator

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing a3d9625 to master...

bors

merged commit a3d9625 into

rust-lang:master

Mar 21, 2024

11 checks passed

Veykril

deleted the rustc-crates branch

March 21, 2024 16:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

stuck at "Building CrateGraph" in rust-lang/rust repo

3 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK