0

Make `type_ascribe!` not a built-in by compiler-errors · Pull Request #122806 ·...

 4 weeks ago
source link: https://github.com/rust-lang/rust/pull/122806
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Conversation

The only weird thing is the macro expansion note. I wonder if we should suppress these 🤔

r? @fmease since you told me about builtin# lol

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

labels

Mar 21, 2024

Member

@fmease fmease

left a comment

Strong!
r=me with or without nits addressed at your convenience

Member

Author

@bors r=fmease rollup

Contributor

📌 Commit a015b90 has been approved by fmease

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Mar 21, 2024

Member

The only weird thing is the macro expansion note. I wonder if we should suppress these 🤔

Not worth it imo. Can be done at some other point once ppl using e.g. offset_of! complain about it.

compiler-errors reacted with thumbs up emoji

bors

merged commit 62e414d into

rust-lang:master

Mar 21, 2024

11 checks passed

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Mar 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fmease

fmease approved these changes
Assignees

fmease

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

None yet

4 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK