`assigning_clones` should respect MSRV by humannum14916 · Pull Request #12511 ·...
source link: https://github.com/rust-lang/rust-clippy/pull/12511
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Contributor
Fixes: #12502
This PR fixes the assigning_clones lint suggesting to use clone_from or clone_into on incompatible MSRVs.
assigning_clones will suggest using either clone_from or clone_into, both of which were stabilized in 1.63. If the current MSRV is below 1.63, the lint should not trigger.
changelog: [assigning_clones]: don't lint when the MSRV is below 1.63.
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Alexendoo (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label
Member
|
Great, thanks! @bors r+ |
Contributor
|
Hi, thanks for the PR, but I'm pretty sure that |
Contributor
Author
|
Whoops! Sorry about that, I really should have double-checked exactly where to apply the MSRV check. I'll start working on a new PR to fix that, it looks like the proper location for the check would be in |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
No milestone
Successfully merging this pull request may close these issues.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK