fix detecting references to packed unsized fields by RalfJung · Pull Request #11...
source link: https://github.com/rust-lang/rust/pull/115583
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
fix detecting references to packed unsized fields #115583
Conversation
Member
Fixes #115396
This is a breaking change, but permitted as a soundness fix.
Collaborator
|
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
Member
Author
|
Ah... we'll need something more clever to keep zerovec working it seems. We could exploit that slices actually have static alignment, only for dyn traits it is truly dynamic. |
This comment has been minimized.
Member
Author
|
Since this is a breaking change, maybe we should ask crater. Also marking for "relnotes" preemptively; not sure how systematically we document small breaking changes? The release note editors should feel free to disregard this if it is considered too minor of a breaking change. |
added the relnotes Marks issues that should be documented in the release notes of the next release. label
Contributor
|
☀️ Try build successful - checks-actions |
Member
Author
|
@craterbot check |
Collaborator
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
added S-waiting-on-crater Status: Waiting on a crater run to be completed.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Collaborator
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
Collaborator
|
🎉 Experiment ⚠️ If you notice any spurious failure please add them to the blacklist! |
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-crater Status: Waiting on a crater run to be completed.
labels
Collaborator
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label
Collaborator
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label
Collaborator
|
🎉 Experiment ⚠️ If you notice any spurious failure please add them to the blacklist! |
removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label
Member
Since it's technically breaking we figured it probably ought to have an FCP, even as a soundness fix. Hopefully we'll get boxes checked quickly for you 🤞 |
Contributor
|
@rfcbot reviewed |
added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised.
and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
labels
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
removed the I-lang-nominated Indicates that an issue has been nominated for discussion during a lang team meeting. label
added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting
and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised.
labels
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
Member
Author
|
@bors r=lcnr |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (48e2462): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 624.03s -> 624.544s (0.08%) |
bors-ferrocene bot
added a commit to ferrocene/ferrocene that referenced this pull request
bors-ferrocene bot
added a commit to ferrocene/ferrocene that referenced this pull request
bors-ferrocene bot
added a commit to ferrocene/ferrocene that referenced this pull request
bors-ferrocene bot
added a commit to ferrocene/ferrocene that referenced this pull request
bors-ferrocene bot
added a commit to ferrocene/ferrocene that referenced this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
None yet
Successfully merging this pull request may close these issues.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK