3

quic: don't support draft versions · Issue #3395 · libp2p/rust-libp2p · GitHub

 7 months ago
source link: https://github.com/libp2p/rust-libp2p/issues/3395
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

quic: don't support draft versions #3395

marten-seemann opened this issue Jan 27, 2023 · 3 comments

Comments

marten-seemann

commented

Jan 27, 2023

•

edited by mxinden

rust-libp2p's QUIC implementation currently supports a long list of versions (obtained by eliciting a Version Negotiation packet): [v1 draft-29 0xff00001e 0xff00001f 0xff000020 0xff000021 0xff000022]

The 0xff... versions are QUIC draft versions (see https://github.com/quicwg/base-drafts/wiki/QUIC-Versions).

We've never deployed any version other than v1 and draft-29 in libp2p, so there's no reason to enable support for these versions.

Overarching tracking issue #2883.

Member

Thank you @marten-seemann for raising and documenting this.

I suggest we drop support for draft-29 along with all other draft versions. See same deprecation on the go-libp2p side libp2p/go-libp2p#2369.

Steps:

  1. Deprecate libp2p_quic::Config::support_draft_29.
  2. Remove libp2p_quic::Config::support_draft_29 and always set endpoint_config.supported_versions to vec![1].

Contributions from the community would be very welcome. Please post here in case you want to pick this up.

mxinden

added difficulty:easy

help wanted

getting-started Issues that can be tackled if you don't know the internals of libp2p very well

labels

Aug 31, 2023

thomaseizinger

changed the title quic: supported versions

quic: don't support draft versions'

Sep 12, 2023

thomaseizinger

changed the title quic: don't support draft versions'

quic: don't support draft versions

Sep 12, 2023

@mxinden @marten-seemann I would like to work on this, please assign to me.
mxinden reacted with rocket emoji

@mxinden @marten-seemann I would like to work on this, please assign to me.

Done! Thank you for your help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted

Projects

None yet

Milestone

No milestone

Development

No branches or pull requests

4 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK