3

Message view: Account chip not displayed when viewing messages in a thread (from...

 8 months ago
source link: https://github.com/thundernest/k-9/pull/7004
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Message view: Account chip not displayed when viewing messages in a thread (from Unified Inbox) #7004

Conversation

Contributor

fixes #6824

PR Description

This PR ensures that when selected unified from drawer settings it should show account name chip in message details when user navigates through threaded view.

Steps to reproduce

  1. Go to Unified Inbox
  2. Click on a message which is not in a message thread.
  3. Enjoy the restyled message view.
  4. Go to Unified Inbox
  5. Click on a message which is part of a message thread - you'll be taken to the thread view
  6. Click on a message in the thread view
  7. Enjoy the "old" message view instead of the restyled one.

Issue video

https://www.loom.com/share/7296a1c056ae4da79f4be36618fc6163?sid=6c162ba2-dc58-4c81-8a5f-0a4c8e76d581

Demo after fix

https://www.loom.com/share/b45920ae61f54f9b9d1e2b7994b890dc?sid=523a7fbc-2b5b-44c6-84ed-8ad958e791a0

This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

cketti

merged commit b0e05ca into

thundernest:main

Jul 11, 2023

2 checks passed

Member

Thanks 👍

Hi,
I just updated to 6.708 and this PR regresses my experience.

I only have one account, so do not want to see account pills in my message view, however as of this PR when opening a message from the unified inbox i get a account chip. This is inconsistent with other folder views where i do not see the chip as i have isSingleAccountMode

Should not always return true if isUnifiedInbox the logic needs to be a bit more complicated

Member

@yparitcher: Please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cketti

cketti approved these changes
Assignees

No one assigned

Labels
None yet
Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Message view: Account chip not displayed when viewing messages in a thread (from Unified Inbox)

3 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK