2
Convert FxAccountsCommon.js to an ES module
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1845252
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Closed
Bug 1845252
Opened 20 days ago
Closed 13 days ago
Convert FxAccountsCommon.js to an ES module
Categories
(Firefox :: Firefox Accounts, task)
Tracking
(bug RESOLVED as FIXED)
RESOLVED
FIXED
118 Branch
| Tracking | Status | |
|---|---|---|
| firefox118 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
(Whiteboard: [esmification-timeline])
FxAccountsCommon.js is a module file which uses a slightly non-standard jsm exports format, and therefore isn't being picked up by automation which is why we haven't spotted it yet.
We should convert it to an ES module as well.
Pushed by [email protected]: https://hg.mozilla.org/integration/autoland/rev/683a87892126 Convert FxAccountsCommon.js to an ES module. r=markh https://hg.mozilla.org/integration/autoland/rev/d58bbd55cb35 Update consumers of FxAccountsCommon to import the ES module directly. r=markh,settings-reviewers,credential-management-reviewers,sync-reviewers,sgalich,Gijs
Backed out for causing mochitests failures in browser_fxa_web_channel.js.
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/sync/browser_fxa_web_channel.js | Unexpected Exception: TypeError: can't access property "ON_PROFILE_CHANGE_NOTIFICATION", FxAccountsCommon is undefined - false == true - {"filename":"chrome://mochitests/content/browser/browser/base/content/test/sync/browser_fxa_web_channel.js","name":"test/<","sourceId":687,"lineNumber":276,"columnNumber":12,"sourceLine":"","asyncCause":null,"asyncCaller":null,"
Flags: needinfo?(standard8)
Fixed tests.
Flags: needinfo?(standard8)
Pushed by [email protected]: https://hg.mozilla.org/integration/autoland/rev/899588327e70 Convert FxAccountsCommon.js to an ES module. r=markh https://hg.mozilla.org/integration/autoland/rev/25069a171ece Update consumers of FxAccountsCommon to import the ES module directly. r=markh,settings-reviewers,credential-management-reviewers,sync-reviewers,sgalich,Gijs
You need to log in
before you can comment on or make changes to this bug.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK