8

CFI: Fix ICE: encode_const: unexpected type [usize by rcvalle · Pull Request #11...

 1 year ago
source link: https://github.com/rust-lang/rust/pull/113708
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

CFI: Fix ICE: encode_const: unexpected type [usize #113708

Conversation

Member

Fixes #100778 and #113366, and complements #106547 by adding support for encoding const parameters.

Collaborator

r? @WaffleLapkin

(rustbot has picked a reviewer for you, use r? to override)

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jul 14, 2023

rcvalle

added the PG-exploit-mitigations Project group: exploit mitigations label

Jul 14, 2023

Member

@compiler-errors compiler-errors

left a comment

This needs rebase

compiler-errors

added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Jul 16, 2023

This comment has been minimized.

Member

Author

This needs rebase

Done. Thank you for your time, @compiler-errors! Much appreciated.

rcvalle

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jul 21, 2023

Contributor

📌 Commit 55dea62 has been approved by compiler-errors

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Jul 26, 2023

Contributor

hourglass Testing commit 55dea62 with merge a59ae33...

Contributor

sunny Test successful - checks-actions
Approved by: compiler-errors
Pushing a59ae33 to master...

bors

added the merged-by-bors This PR was explicitly merged by bors label

Jul 27, 2023

Contributor

eyes Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

:( bors

@bors retry

Contributor

hourglass Testing commit 55dea62 with merge d150dbb...

Collaborator

Finished benchmarking commit (a59ae33): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Cycles

Results

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 649.74s -> 650.357s (0.09%)

Contributor

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing d150dbb to master...

bors

merged commit d150dbb into

rust-lang:master

Jul 27, 2023

12 checks passed

Collaborator

Finished benchmarking commit (d150dbb): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.6% [0.6%, 0.6%] 1
Regressions x
(secondary)		 - - 0
Improvements white_check_mark
(primary)		 - - 0
Improvements white_check_mark
(secondary)		 -0.6% [-0.6%, -0.5%] 2
All xwhite_check_mark (primary) 0.6% [0.6%, 0.6%] 1

Max RSS (memory usage)

Results

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 656.285s -> 653.837s (-0.37%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

compiler-errors

compiler-errors approved these changes
Labels
merged-by-bors This PR was explicitly merged by bors PG-exploit-mitigations Project group: exploit mitigations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.73.0

Development

Successfully merging this pull request may close these issues.

ICE: encode_const: unexpected type [usize; 1] with -Clto -Zsanitizer=cfi

7 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK