2

Fix missing attribute merge on glob foreign re-exports by GuillaumeGomez · Pull...

 9 months ago
source link: https://github.com/rust-lang/rust/pull/114012
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Fix missing attribute merge on glob foreign re-exports #114012

Conversation

Fixes #113982.

The attributes were not merged with the import's in case of glob re-export of foreign items.

r? @notriddle

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

labels

Jul 24, 2023

Contributor

@bors r+

Contributor

pushpin Commit 7150e35 has been approved by notriddle

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Jul 26, 2023

Contributor

hourglass Testing commit 7150e35 with merge 6908c73...

Contributor

sunny Test successful - checks-actions
Approved by: notriddle
Pushing 6908c73 to master...

1 similar comment

bors

added merged-by-bors This PR was explicitly merged by bors

labels

Jul 26, 2023

bors

merged commit 6908c73 into

rust-lang:master

Jul 26, 2023

12 checks passed

Collaborator

Finished benchmarking commit (6908c73): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Cycles

Results

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.146s -> 650.44s (0.05%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Urgau

Urgau left review comments
Labels
merged-by-bors This PR was explicitly merged by bors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.73.0

Development

Successfully merging this pull request may close these issues.

Doc feature banners won't show up when re-exporting items with wildcard

6 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK