3
Clicking the subtitle options displayed over the PiP toggle will activate pip in...
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1775328
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
bugzilla.mozilla.org will be down for maintenance this Saturday December 3rd starting at 5:00 PM UTC.
The maintenance window should be no more than two hours. Thanks!
The maintenance window should be no more than two hours. Thanks!
Closed
Bug 1775328
Opened 5 months ago
Closed 4 days ago
Clicking the subtitle options displayed over the PiP toggle will activate pip instead of the menu displayed over it (WebVTT sub video)
Categories
(Toolkit :: Picture-in-Picture, defect)
Tracking
(bug RESOLVED as FIXED)
RESOLVED
FIXED
109 Branch
People
(Reporter: danibodea, Assigned: kpatenio)
References
(Depends on 1 open bug)
Details
(Whiteboard: [fidefe-MR1-2022])
Note
- When the user load some video player (like this one), plays it, opens the "CC" menu and cliks on an option displayed over the PiP toggle, he will notice that the PiP is launched and the setting is not activated.
** Found in**
- Nightly v103.0a1
Affected versions
- Nightly v103.0a1
Affected platforms
Steps to reproduce
- Load https://iandevlin.com/html5/track/index-multiple.html
- Play it
- Click "CC"
- Click Deutch or English, but in an area over the PiP toggle.
Expected result
- The subtitle track is selected and the PiP is NOT launched.
Actual result
- The PiP is launched and the track is NOT selected.
Regression range
- not a regression.
Additional notes
- The track is sometimes selected while the PiP is also launched, but that appears intermittent.
Points: --- → 5
Attachment #9301902 -
Attachment description: WIP: Bug 1775328 - do not launch PiP if video controls text track list menu intersects the PiP toggle visually. r=#pip-reviewers! → Bug 1775328 - do not launch PiP if video controls text track list menu intersects the PiP toggle visually. r=#pip-reviewers!
Pushed by [email protected]: https://hg.mozilla.org/integration/autoland/rev/9db86df92517 do not launch PiP if video controls text track list menu intersects the PiP toggle visually. r=cmkm,mhowell
Backed out for failures on browser_toggle_videocontrols.js
[task 2022-11-17T16:35:40.989Z] 16:35:40 INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_toggle_videocontrols.js | Toggle reached target opacity. - true == true -
[task 2022-11-17T16:35:40.990Z] 16:35:40 INFO - Buffered messages finished
[task 2022-11-17T16:35:40.990Z] 16:35:40 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_toggle_videocontrols.js | A track should be enabled - "undefined" == true - got (void 0), expected true (operator ==)
[task 2022-11-17T16:35:40.990Z] 16:35:40 INFO - Stack trace:
[task 2022-11-17T16:35:40.990Z] 16:35:40 INFO - ok@resource://specialpowers/SpecialPowersSandbox.sys.mjs:84:21
[task 2022-11-17T16:35:40.991Z] 16:35:40 INFO - @chrome://mochitests/content/browser/toolkit/components/pictureinpicture/tests/browser_toggle_videocontrols.js:131:11
[task 2022-11-17T16:35:40.991Z] 16:35:40 INFO - Verifying that no Picture-in-Picture window is open.
[task 2022-11-17T16:35:40.992Z] 16:35:40 INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "chrome://global/content/elements/videocontrols.js" line: 1305}]
[task 2022-11-17T16:35:41.069Z] 16:35:41 INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-11-17T16:35:41.069Z] 16:35:41 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_toggle_videocontrols.js | Found a Picture-in-Picture window unexpectedly. -
[task 2022-11-17T16:35:41.069Z] 16:35:41 INFO - Stack trace:
[task 2022-11-17T16:35:41.069Z] 16:35:41 INFO - chrome://mochikit/content/browser-test.js:test_ok:1459
[task 2022-11-17T16:35:41.069Z] 16:35:41 INFO - chrome://mochitests/content/browser/toolkit/components/pictureinpicture/tests/browser_toggle_videocontrols.js:null:144
[task 2022-11-17T16:35:41.075Z] 16:35:41 INFO - Leaving test bound
[task 2022-11-17T16:35:41.429Z] 16:35:41 INFO - GECKO(2260) | MEMORY STAT | vsize 8229MB | residentFast 389MB | heapAllocated 133MB
[task 2022-11-17T16:35:41.430Z] 16:35:41 INFO - TEST-OK | toolkit/components/pictureinpicture/tests/browser_toggle_videocontrols.js | took 1597ms
Flags: needinfo?(kpatenio)
 |
Assignee | |
Comment 12•15 days ago
|
||
For this log, there's two failed assertions:
- firstly, the closed captions text track did not enable as expected
- secondly, the test is detecting a PiP window intitializing
For the first failure, it's possible that we're asserting too early and need to wait until a track is enabled. However, that doesn't explain why we're detecting a PiP window (there should be no new window). This failure is observed in other tests in the same push too. Will need to see where it's originating from.
Flags: needinfo?(kpatenio)
Pushed by [email protected]: https://hg.mozilla.org/integration/autoland/rev/5d97bf5e15fd do not launch PiP if video controls text track list menu intersects the PiP toggle visually. r=cmkm,mhowell
Backed out for causing failures on browser_toggle_videocontrols.js
Flags: needinfo?(kpatenio)
I updated the patch to include different solution to this ticket, which should greatly simplify the test for it.
Flags: needinfo?(kpatenio)
Pushed by [email protected]: https://hg.mozilla.org/integration/autoland/rev/85db4d3ca851 do not launch PiP if video controls text track list menu intersects the PiP toggle visually. r=cmkm,mhowell,mconley
Status: ASSIGNED → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in
before you can comment on or make changes to this bug.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK