5

make `TypeError` impl `Copy` by compiler-errors · Pull Request #100510 · rust-la...

 2 years ago
source link: https://github.com/rust-lang/rust/pull/100510
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

r? @ghost

All reactions

rustbot

added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label

6 days ago

Collaborator

rust-timer commented 6 days ago

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

Contributor

bors commented 6 days ago

hourglass Trying commit 1db3aa1 with merge e1fce09...

Contributor

bors commented 6 days ago

sunny Try build successful - checks-actions
Build commit: e1fce09 (e1fce0925985ca02299b27bba245048945cd0b22)

Collaborator

rust-timer commented 6 days ago

Collaborator

rust-timer commented 6 days ago

Finished benchmarking commit (e1fce09): comparison url.

Instruction count

  • Primary benchmarks: x relevant regressions found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions x
(primary)		 0.9% 1.0% 2
Regressions x
(secondary)		 - - 0
Improvements white_check_mark
(primary)		 - - 0
Improvements white_check_mark
(secondary)		 - - 0
All xwhite_check_mark (primary) 0.9% 1.0% 2

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change

  2. number of relevant changes

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-perf Status: Waiting on a perf run to be completed.

labels

6 days ago

Member

Author

compiler-errors commented 6 days ago

Uh, I wonder if this is noise.

@rust-timer build e1fce09

Member

Author

compiler-errors commented 6 days ago

Ugh, can't re-run rust-timer? :s

Member

Author

compiler-errors commented 6 days ago

I'm gonna try one more time to see if that was just noise

Collaborator

rust-timer commented 6 days ago

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

rustbot

added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label

6 days ago

Contributor

bors commented 6 days ago

hourglass Trying commit b1787a6 with merge 1a017b0...

Contributor

bors commented 6 days ago

sunny Try build successful - checks-actions
Build commit: 1a017b0 (1a017b030381225228ca0969ae778585d8d213f7)

Collaborator

rust-timer commented 6 days ago

Collaborator

rust-timer commented 6 days ago

Finished benchmarking commit (1a017b0): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: white_check_mark relevant improvement found
mean1 max count2
Regressions x
(primary)		 - - 0
Regressions x
(secondary)		 - - 0
Improvements white_check_mark
(primary)		 - - 0
Improvements white_check_mark
(secondary)		 -0.2% -0.2% 1
All xwhite_check_mark (primary) - - 0

Max RSS (memory usage)

Results

Cycles

Results

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change

  2. number of relevant changes

rustbot

removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label

6 days ago

Member

Author

compiler-errors commented 5 days ago

so it was just noise anger

Member

Author

compiler-errors commented 5 days ago

r? compiler

Contributor

jackh726 commented 5 days ago

@bors r+

Contributor

bors commented 5 days ago

pushpin Commit b1787a6 has been approved by jackh726

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

5 days ago

Contributor

jackh726 commented 5 days ago

@bors r-
needs rebase

bors

added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

5 days ago

Member

Author

compiler-errors commented 5 days ago

@bors r=jackh726

Contributor

bors commented 5 days ago

pushpin Commit 75dfe55 has been approved by jackh726

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

labels

5 days ago

Contributor

bors commented 5 days ago

hourglass Testing commit 75dfe55 with merge 76c427d...

Contributor

bors commented 5 days ago

sunny Test successful - checks-actions
Approved by: jackh726
Pushing 76c427d to master...

bors

added the merged-by-bors This PR was explicitly merged by bors label

5 days ago

bors

merged commit 76c427d into

rust-lang:master

5 days ago

11 checks passed

rustbot

added this to the 1.65.0 milestone

5 days ago

Collaborator

rust-timer commented 5 days ago

Finished benchmarking commit (76c427d): comparison url.

Instruction count

  • Primary benchmarks: x relevant regression found
  • Secondary benchmarks: x relevant regression found
mean1 max count2
Regressions x
(primary)		 1.0% 1.0% 1
Regressions x
(secondary)		 0.2% 0.2% 1
Improvements white_check_mark
(primary)		 - - 0
Improvements white_check_mark
(secondary)		 - - 0
All xwhite_check_mark (primary) 1.0% 1.0% 1

Max RSS (memory usage)

Results

Cycles

Results

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change

  2. number of relevant changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

jackh726

Labels
merged-by-bors This PR was explicitly merged by bors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

None yet

5 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK