2

Commit message guidelines

 1 year ago
source link: https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Commit message guidelines · GitHub

Instantly share code, notes, and snippets.

Commit message guidelines

Commit Message Guidelines

Short (72 chars or less) summary

More detailed explanatory text. Wrap it to 72 characters. The blank
line separating the summary from the body is critical (unless you omit
the body entirely).

Write your commit message in the imperative: "Fix bug" and not "Fixed
bug" or "Fixes bug." This convention matches up with commit messages
generated by commands like git merge and git revert.

Further paragraphs come after blank lines.

- Bullet points are okay, too.
- Typically a hyphen or asterisk is used for the bullet, followed by a
  single space. Use a hanging indent.

Example for a commit message

Add CPU arch filter scheduler support

In a mixed environment of…

A properly formed git commit subject line should always be able to complete the following sentence

If applied, this commit will <your subject line here>

Rules for a great git commit message style

  • Separate subject from body with a blank line
  • Do not end the subject line with a period
  • Capitalize the subject line and each paragraph
  • Use the imperative mood in the subject line
  • Wrap lines at 72 characters
  • Use the body to explain what and why you have done something. In most cases, you can leave out details about how a change has been made.

Information in commit messages

  • Describe why a change is being made.
  • How does it address the issue?
  • What effects does the patch have?
  • Do not assume the reviewer understands what the original problem was.
  • Do not assume the code is self-evident/self-documenting.
  • Read the commit message to see if it hints at improved code structure.
  • The first commit line is the most important.
  • Describe any limitations of the current code.
  • Do not include patch set-specific comments.

Details for each point and good commit message examples can be found on https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages

References in commit messages

If the commit refers to an issue, add this information to the commit message header or body. e.g. the GitHub web platform automatically converts issue ids (e.g. #123) to links referring to the related issue. For issues tracker like Jira there are plugins which also converts Jira tickets, e.g. Jirafy.

In header:

[#123] Refer to GitHub issue…
CAT-123 Refer to Jira ticket with project identifier CAT…

In body:

…
Fixes #123, #124

Sources

With the current version (revision #2) the subject line is ignored by git if it includes an issue id. The second revision introduces a style change in subject format that proposes the use of #<IssueID> at the start of the subject. However, git ignore lines that start with # character thus making the body of the commit the actual subject. I propose to switch back to revision #1 or introduce a different style. We can add the referring issue id to an independent line after the subject. Something like:

Short (72 chars or less) summary

Refer to issue #<IssueId>

More detailed explanatory text. Wrap it to 72 characters. The blank
line separating the summary from the body is critical (unless you omit
the body entirely).

Write your commit message in the imperative: "Fix bug" and not "Fixed
bug" or "Fixes bug." This convention matches up with commit messages
generated by commands like git merge and git revert.

Further paragraphs come after blank lines.

- Bullet points are okay, too.
- Typically a hyphen or asterisk is used for the bullet, followed by a
  single space. Use a hanging indent.

To further support @GeorkeGkas's comment, the summary line is one of the more important parts to get right and with limited space, using it for metadata (the issue ID) is taking away from that limited space.

Most metadata is put at the end of a commit message in a rfc822 header line format.

Fixes: #1234
Signed-off-by: Me [email protected]
Tested-by: You [email protected]
...

If you're just referencing an issue:
Issues: #1234

Just my 2c.

What is the generally accepted practice if a commit contains numerous unrelated changes that cannot be described succinctly in just 50 characters?

For example, if a recent project involves patching a vulnerability in the login handler, removing unused image and sound files, refactoring code and adding better comments, improving performance of the main event loop, fixing bugs in the collision detection algorithm, etc. There is no possible way all of that can fit into a subject line. Yet a generic subject line like "Addressed a lot of lingering issues (see below)" doesn't conform to the conventions described above either.

Any advice would be greatly appreciated. Thanks!

What to do when including long URLs in the body?

@djanowski, you can either

  1. put them on it's own line
Fetching an object is done by using the technique explained at
https://www.url.com/some/very/long/url/that/easily/exceeds/72/characters/per/line
and…

(a line should only exceed 72 characters if the line can't be split. There are also exceptions to this rule, e.g. if you're using code in the commit message)

  1. or reference them
Fetching an object is done by using the technique explained at [1] and…
…
[1] https://www.url.com/some/very/long/url/that/easily/exceeds/72/characters/per/line

Since in many cases the reference is embedded in a paragraph, I prefer the second option. It keeps the line formatting clean and doesn't interrupt your reading.

@sorcerykid, http://whatthecommit.com/ (refresh a few times until you find the commit message that suites your changes wink)

There isn't really an "accepted practice" here. Maybe you still can split your changes into multiple commits?
Leaving following note here:

Commit Often, Perfect Later, Publish Once

I want to propose a possible improvement in References in commit messages section. There are times, not very often but exists, that a commit refers to more than one issue. Most of the times, when this happens, a commit will not refer to more than 2 -maybe 3- issues. To be able to reference multiple issues in the header I propose the following format:

[#123, #879] Refer to GitHub issue…

I would like to read what is your reaction to this update. smile

rsp commented on Apr 17, 2018

@robertpainsi +1 Excellent guideline, thanks for sharing that. I would only have one comment that I don't generally recommend putting any references to issues or pull requests into the commit message subjects (first line) because I like them to strictly adhere to the "Do something" style with no information that is not meaningful by itself, especially when viewed outside of GitHub like in the command line, or in the case of moving the project to other git hosting, or forking, in which case the issue/PR numbers will be invalid. For that reason I recommend putting those always in the body of the commit message instead. Other than that I think your guideline is really good and I might add some of your commit message rules to my guideline if you don't mind. grin

Thank you so much for the knowledge.

What is the generally accepted practice if a commit contains numerous unrelated changes that cannot be described succinctly in just 50 characters?

For example, if a recent project involves patching a vulnerability in the login handler, removing unused image and sound files, refactoring code and adding better comments, improving performance of the main event loop, fixing bugs in the collision detection algorithm, etc. There is no possible way all of that can fit into a subject line. Yet a generic subject line like "Addressed a lot of lingering issues (see below)" doesn't conform to the conventions described above either.

Any advice would be greatly appreciated. Thanks!

How about splitting the changes into multiple commits if they are so very unrelated? That would not only make your commit messages specific but also keep similar changes together in one commit.

How about splitting the changes into multiple commits if they are so very unrelated?

Agreed! This is the only acceptable way to do it. Some projects ask contributors to squash commits together, but this does not usually apply when the commits contain unrelated changes. In fact, unrelated changes should probably be in a separate pull request, let alone a separate commit.

Aim for atomic commits: each commit should do one thing only. Similarly, a pull request should aim to fix one bug or implement one new feature. It should only contain multiple commits if that is required to fix the bug or implement the feature.

If your commit / pull request title contains the word "and" then you probably should have used two commits / pull requests.

Aim for atomic commits: each commit should do one thing only. Similarly, a pull request should aim to fix one bug or implement one new feature. It should only contain multiple commits if that is required to fix the bug or implement the feature.

I seems a bit limited, in the wrong way, that a pull request with one feature, only should consist of one commit. I can easily have 8-10 commits to implement a feature.
The idea with commits are to commit often, so you easily can revert and easily see the progress.
I also often do squashes, but more often I merge master into my branch and I push a couple of 3-4 times a day to my own branch.

I seems a bit limited [...] that a pull request with one feature, only should consist of one commit.

It's something to aspire to rather than a strict requirement. What counts as "one feature" is ususally determined by what a user wrote in a single issue in the tracker, but we all know that some features are bigger than others. I said multiple commits are allowed, if necessary.

The most important thing is to ensure that that each commit does exactly one thing: no more, no less. Developers look at commits when they try to understand your code changes. If there are too many commits then the history will be too long, but if there are too few then the diffs will be too long and it will be hard to understand what they do from the summary alone.

The idea with commits are to commit often, so you easily can revert and easily see the progress.

Yes indeed, but that is mainly for when you are working on your own branch, and this guide doesn't really apply in that situation. In fact I would recommend you ignore this guide entirely on your own branch, because writing detailed commit messages is a burden that will discourage you from committing early and often. However, once you have got something working, you need to tidy it up a bit before sharing it with other people. That's where this guide comes in, and tools like --fixup and --autosquash help a lot too.

What is the generally accepted practice if a commit contains numerous unrelated changes that cannot be described succinctly in just 50 characters?
For example, if a recent project involves patching a vulnerability in the login handler, removing unused image and sound files, refactoring code and adding better comments, improving performance of the main event loop, fixing bugs in the collision detection algorithm, etc. There is no possible way all of that can fit into a subject line. Yet a generic subject line like "Addressed a lot of lingering issues (see below)" doesn't conform to the conventions described above either.
Any advice would be greatly appreciated. Thanks!

How about splitting the changes into multiple commits if they are so very unrelated? That would not only make your commit messages specific but also keep similar changes together in one commit.

+1

What is the generally accepted practice if a commit contains numerous unrelated changes that cannot be described succinctly in just 50 characters?

How do you do this all in the terminal, specifically referencing issues and other commits?

I'd wish there was a way to stage/pause your commit and use the GitHub interface to comment on it before finishing the push or pull request.

Does GitHub support markdown in the commit messages?

jesus2099 commented on Dec 31, 2019

edited
  1. or reference them
Fetching an object is done by using the technique explained at [1] and…
…
[1] https://www.url.com/some/very/long/url/that/easily/exceeds/72/characters/per/line

We can use the more standard syntax below, so it can be interpreted more likely:

Fetching an object is done by using the technique explained at [cool page] and…
…

[cool page]: https://www.url.com/some/very/long/url/that/easily/exceeds/72/characters/per/line "optional tooltip"
[Official Markdown syntax for links]: https://daringfireball.net/projects/markdown/syntax#link "search reference-style in there"

Put all references in their own paragraph(s) and syntax is [refname]: url (with : a colon).

Result:

Fetching an object is done by using the technique explained at this cool page and…


Official Markdown syntax for links says Reference-style should be:

This is [an example][id] and [another example] [id] or even [id][] reference-style link.
…

[id]: http://example.com/  "Optional Title Here"

But it has been pretty common to just use [id] or [an example] instead of [id][] or [an example][] in the text paragraph.

Thank you very much for sharing this knowledge

Thanks A Lot hugs

Masterrazz commented on Oct 23, 2020

edited

Can anyone help me plz. When I run a c++ code on vs code then in output section show access is denied . So what issue in my window 10 lp. Thanks a lot $many many whishess for u'r dream in advance

Mail me plz. [email protected] .becoz i'm new here

Topics

  • C/C++ for Visual Studio Code

C/C++ support for Visual Studio Code is provided by a Microsoft C/C++ extension to enable cross-platform C and C++ development on Windows, Linux, and macOS.

Getting started

  • C/C++ compiler and debugger

The C/C++ extension does not include a C++ compiler or debugger. You will need to install these tools or use those already installed on your computer.

Popular C++ compilers are:

  • GCC on Linux
  • GCC via Mingw-w64 on Windows
  • Microsoft C++ compiler on Windows
  • Clang for XCode on macOS

"Make sure your compiler executable is in your platform path so the extension can find it." You can check availability of your C++ tools by opening the Integrated Terminal (⌃ (Windows, Linux Ctrl+)) in VS Code and try running the executable (for example g++ --help).
Install the Microsoft C/C++ extension#

Open VS Code.
Click the Extensions view icon on the Sidebar (⇧⌘X (Windows, Linux Ctrl+Shift+X)).
Search for c++.
Click Install.

Hello World tutorials


Get started with C++ and VS Code with Hello
World tutorials for your environment:

  • GCC on Windows
  • Microsoft C++ on Windows
  • GCC on Linux
  • GCC on Windows Subsystem For Linux
  • Clang/LLVM on macOS
Documentation

You can find more documentation on using the Microsoft C/C++ extension under the C++ section, where you'll find topics on:

Debugging
Editing
Settings
FAQ
Remote Development

VS Code and the C++ extension support Remote Development allowing you to work over SSH on a remote machine or VM, inside a Docker container, or in the Windows Subsystem for Linux (WSL).

To install support for Remote Development:

Install the VS Code Remote Development Extension Pack.
If the remote source files are hosted in WSL, use the Remote - WSL extension.
If you are connecting to a remote machine with SSH, use the Remote - SSH extension.
If the remote source files are hosted in a container (for example, Docker), use the Remote - Containers extension.

Feedback

If you run into any issues or have suggestions for the Microsoft C/C++ extension, please file issues and suggestions on GitHub. If you haven't already provided feedback, please take this quick survey to help shape this extension for your needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment


About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK