Add new ThinBox type for 1 stack pointer wide heap allocated trait objects by ya...
source link: https://github.com/rust-lang/rust/pull/90066
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
r? @kennytm
(rust-highfive has picked a reviewer for you, use r? to override)
added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label
added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
labels
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The latest upstream changes (presumably #90067) made this pull request unmergeable. Please resolve the merge conflicts.
added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label
This comment has been minimized.
This comment has been minimized.
added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label
This comment has been minimized.
added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
labels
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
The latest upstream changes (presumably #95552) made this pull request unmergeable. Please resolve the merge conflicts.
@@ -152,6 +153,7 @@
#![feature(fundamental)]
#![cfg_attr(not(test), feature(generator_trait))]
#![feature(lang_items)]
#![feature(let_else)]
Posted a few comments, and un-resolved one other comment that didn't get addressed.
LGTM otherwise; r=me with those addressed.
This comment has been minimized.
This comment has been minimized.
The latest upstream changes (presumably #95798) made this pull request unmergeable. Please resolve the merge conflicts.
@bors r=joshtriplett
Commit a87a0d0 has been approved by joshtriplett
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK