1

Upgrade map_flatten to complexity by camsteffen · Pull Request #8054 · rust-lang...

 2 years ago
source link: https://github.com/rust-lang/rust-clippy/pull/8054
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Copy link

Contributor

mikerite commented 11 days ago

Looks good to me but the one thing I would consider is if this lint belongs in style or complexity.

Note that classifying the lint as complexity discussed in #5846 and they went with pedantic.

I would be surprised if anyone objects to moving it to warn-by-default:

I ran it on around 1000 top crates and I got 11 warnings. The worse was plotters with 4.

Warnings - 11

criterion-0.3.5 - 3
gif-0.11.3 - 1
plotters-0.3.1 - 4
racer-2.1.48 - 1
raw-cpuid-10.2.0 - 1
rustyline-9.0.0 - 1

It's allowed only once on Noisy Clippy.


About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK