1

Move the `ockam_vault_core` create into `ockam_core`. · Issue #2288 · ockam-netw...

 2 years ago
source link: https://github.com/ockam-network/ockam/issues/2288
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Copy link

Member

thomcc commented 9 days ago •

edited

We're trying to reduce the number of crates, and part of that is moving ockam_vault_core into a new vault submodule of ockam_core. I think this basically looks like

  1. Make a new pub mod vault; in ockam_core.

    • Note: unlike the other modules, I think we shouldn't pub use vault::* from the root here, since we'd like to move away from this.

  2. Move the code from ockam_vault_core/src/* to a new ockam_core/src/vault/* directory (and updating anything necessary, renaming lib.rs to mod.rs, renaming any references that were previously crate::Something to be crate::vault::Something)

  3. Update the doc comments so that it says "this module" rather than "this crate" and such. (Ask if you need help wording this).

  4. Change uses of ockam_vault_core::Foo to use ockam_core::vault::Foo across our crates.

  5. Delete the ockam_vault_core crate, and any references to it (be sure to check .github/workflows, and to do a search for ockam_vault_core).

That's the basic idea anyway (I may have missed something). Feel free to ask questions if anything is unclear.


report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK