Affected versions

• 92.0a1 (20210727094543)
• 91.0b8 (20210727214000)
• 90.0.2 (20210721174149)

Affected platforms

• Windows 10x64
• Windows 7x64
• macOS 11
• Ubuntu 18.04

Preconditions

• have at least one saved address

Steps to reproduce

1. Open https://luke-chang.github.io/autofill-demo/basic.html and hover over the saved addresses.

Expected result

• Previews are displayed inside fields on hover.

Actual result

• Only a yellow bar is shown.

Regression range

• Nightly from 2021-02-02 is not affected. I will search for one ASAP.

Notes

• Attached a screen recording showing an older version and 91.0b8.

Hi emilio, it seems that Bug 1698315 causes the regression, could you help take a look at this? thanks!

Sure. How do I get the address autofill? At least when I try to autofill the form here I don't get any suggestions, even on a clean build...

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

Sure. How do I get the address autofill? At least when I try to autofill the form here I don't get any suggestions, even on a clean build...

Hello! For autofill to work you will need to set extensions.formautofill.available:on and browser.search.region:US. Restart the browser and add some addresses by pressing Saved Addresses under Forms and Autofill inside about:preferences#privacy. You can use https://www.fakepersongenerator.com/ site or add random ones. Note that Country or Region needs to be on United States.

Thank you.

The style system uses the changed bits to compute the old state, so if
it's inaccurate it might cause styles to be incorrectly invalidated.

This causes issues because with the next patch the autofill jsm
calls removeManuallyManagedStates(AUTOFILL), then
addManuallyManagedStates(AUTOFILL | AUTOFILL_PREVIEW), and if the input
didn't have AUTOFILL before we'd incorrectly detect it as not changing
with the next patch.

Also make them not virtual anymore since nobody overrides them. An
alternative to this would be to assert that we don't yet have the state
we're adding (or that we have the state we're removing), and handle it
in the callers. But this is a bit more convenient.

This is useful so that author rules for :autofill also work for the
autofill preview.

It also makes the UA sheet in forms.css simpler (otherwise we'd need to
tweak the selectors to put :-moz-autofill-preview everywhere we put
:autofill).

Depends on D122013

They're not the prettiest, but that's all that needs to happen right now for
autofill to work.

Depends on D122015