4

Remove save code from screenshots

 3 years ago
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1705749
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Closed Bug 1705749 Opened 1 month ago Closed 25 days ago

Remove save code from screenshots

Categories

(Firefox :: Screenshots, task, P3)

Tracking

(bug RESOLVED as FIXED)

RESOLVED FIXED

90 Branch

Tracking Status firefox90 --- fixed

People

(Reporter: emalysz, Assigned: xtbpvexf)

References

(Blocks 1 open bug)

Details

(Whiteboard: [outreachy-2021-screenshots])

+++ This bug was initially created as a clone of Bug #1705744 +++

Saving a screenshot is no longer supported and can be removed from screenshots.

Please ensure screenshots still work when submitting a patch

default.jpg

Assignee

Comment 1

1 month ago

Can I be assigned to this?

Sure! Please add emalysz and sfoster as reviewers for your screenshots patches

hyy. the bug seems unassigned to me. can I work on itt?
@dawit are you working on it? if yes, please do inform me and make yourself an assignee.

Flags: needinfo?(sfoster)
Flags: needinfo?(fc85dlup)
Flags: needinfo?(emalysz)
default.jpg

Assignee

Comment 4

28 days ago

Hello. Yes I'm working on this issue. Just hadn't had the time to finish it yet. I don't know if it is possible to make myself an assignee though. Can you help with this please?

Flags: needinfo?(fc85dlup)

Hi Dawit,

You can do this by "Edit bug" --> "Assignee" and type your username. I went ahead and did it for you, but for the future, please assign yourself to any bugs you're actively working on. Thanks for taking it!

Assignee: nobody → fc85dlup
Status: NEW → ASSIGNED
Flags: needinfo?(sfoster)
Flags: needinfo?(emalysz)
default.jpg

Assignee

Comment 6

27 days ago

Good to know. Thanks.

default.jpg

Assignee

Comment 8

26 days ago

I was assigned to this task.

Flags: needinfo?(kamaraju428)

Sorry Dawit .emalysz only told you can submit anything there is nothing with the assignee . And I have been working on this a week ago.

Thanks

Flags: needinfo?(kamaraju428)
default.jpg

Assignee

Comment 10

26 days ago

You should have at least said something about it. It took me a long time to find beginner-friendly tasks on this project. I was glad this was assigned to me, and I spend multiple hours trying to figure it out. That's not very professional.

Flags: needinfo?(sfoster)
Flags: needinfo?(kamaraju428)
Flags: needinfo?(emalysz)

Huhh see.. all the issues are kinda 'submit a patch and make urself an assignee' type . Then this kinda things are familiarly happening, I found some dead codes in my shots files and even removed in my working directory waiting for the commit then what happened someone committed the same codes before a few minutes to my commit that I've been tirelessly found and removed . You know how sad it was . and Im really really sorry for this.If its hurts you. Hoping u understand the situation.

Thanks

Flags: needinfo?(kamaraju428)

Hi everyone,

Thanks for both taking the time to look at this issue! Dhanesh, if an issue is assigned, that means the bug is already being worked on by another contributor/employee even if there is no patch associated with it yet. If there has been no activity on a bug for a few months, it's good practice to needinfo? the curreent assignee to see if they have any intention of picking up the bug again.

That being said, this issue is still assigned to Dawit, who should still have the opportunity to submit a patch. For that reason, I'm going to mark Dhanesh's patch as "obsolete".

This was a totally understandable mistake getting involved into a new project and is part of the learning curve. It's great practice to start looking at the screenshots code!

Flags: needinfo?(sfoster)
Flags: needinfo?(emalysz)
default.jpg
Reporter

Updated

26 days ago
Attachment #9217154 - Attachment is obsolete: true
default.jpg
Reporter

Updated

26 days ago
Attachment #9217154 - Attachment is obsolete: true
default.jpg

Assignee

Comment 15

26 days ago

I made a mistake when I was working on the task and submitted the patch. I didn't know how to edit a patch, so I resubmitted and new one. The former one is invalid.

You need to log in before you can comment on or make changes to this bug.

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK