[Proton] When ETP is diasbled there is a striped background
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1704078
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
[Proton] When ETP is diasbled there is a striped background
Categories
(Firefox :: Protections UI, defect, P2)
Tracking
(bug has been fixed and VERIFIED)
90 Branch
People
(Reporter: oana.botisan, Assigned: ukohasarah)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [proton-door-hangers] [priority:2b] [proton-uplift])
Affected versions
- Firefox 89.0a1
Affected platforms
- Windows 10 x64
- Ubuntu 18.04 x64
- macOS 10.15
Precondition
The following prefs are set to true in about:config:
- browser.proton.enabled
- browser.proton.doorhangers.enabled (for preliminary testing this also required, until the work is moved to the main pref)
Steps to reproduce
- Go to https://www.reddit.com/
- Click on the shield icon and turn off ETP.
- Click on the shiled icon again and observe panel.
Expected result
- There is a one colored background.
Actual result
- There is a striped background.
Regression range
- This is not a regression.
Additional notes
- Please look at the attached image. It's the one from the specs.
Verified the fix using Nightly 90.0a1 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.15. The issue is not reproducing anymore.
Comment on attachment 9216568 [details]
Bug 1704078 - Remove striped background [Proton] When ETP is disabled r=prathiksha
Beta/Release Uplift Approval Request
- User impact if declined: Required for MR1 / Proton
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is a very contained, well-understood CSS change.
- String changes made/needed: None.
Comment on attachment 9216568 [details]
Bug 1704078 - Remove striped background [Proton] When ETP is disabled r=prathiksha
Approved for 89 Beta 3, thanks.
Verified the fix using Firefox 89.0b3 on Windows 10 x64, macOS 10.15 and Ubuntu 18.04 x64. The issue is not reproducing.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK