Github stop displaying and serving authorship information by hi-rustin · Pull Re...
source link: https://github.com/rust-lang/docs.rs/pull/1322
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
This is wrong, it also prevents viewing pages by the owner. It should only remove get_releases_by_author.
@jyn514 Do we need to rename these api and routing parameters?
I think it would be good to rename where appropriate, but that seems less important to be done straight away. We also need to stop recording the data we're no longer displaying, and then delete the existing data from the database. I think it would make sense to open a local tracking issue here so those steps can be done independently.
Can you add a test for what happens when you try to request an owner instead of an author? There are some examples near the end of src/web/releases.rs.
Can you add a test for what happens when you try to request an owner instead of an author? There are some examples near the end of src/web/releases.rs.
I think we already have owners_page and owners_pagination tests.
@jyn514 Thank you for your review.
Can you add a test for what happens when you try to request an owner instead of an author? There are some examples near the end of src/web/releases.rs.
I think we already have
owners_pageandowners_paginationtests.
Sorry, I meant to say "an author instead of an owner". The existing tests are only for when the owner is found, not when there's an error.
Can you add a test for what happens when you try to request an owner instead of an author? There are some examples near the end of src/web/releases.rs.
I think we already have
owners_pageandowners_paginationtests.Sorry, I meant to say "an author instead of an owner". The existing tests are only for when the owner is found, not when there's an error.
Add nonexistent_owner_page for it.
@jyn514 I think it's ready for review.
@rustbot label: -S-waiting-on-author +S-waiting-on-review
Add nonexistent_owner_page for it.
Thanks. That shows the error message was wrong: you returned the right error, but the handler ignores it, which was the long-standing bug the comments didn't describe very well. I opened #1326 fixing it, I'd prefer to wait for that before merging.
Thanks. That shows the error message was wrong: you returned the right error, but the handler ignores it, which was the long-standing bug the comments didn't describe very well. I opened #1326 fixing it, I'd prefer to wait for that before merging.
Got it. Besides this issue, is there anything else that needs to be changed in this PR?
@hi-rustin I don't plan to review this again until #1326 is merged. Feel free to ping me if I forget :)
@@ -90,21 +90,6 @@
</li>
</ul>
</div>
{# Show the crate authors #}
hi-rustin 11 days ago
Author
Contributor
I am currently unable to check the topbar related pages because I am having problems with add-essential-files.
See: rust-lang/rustwide#41 (comment)
So I don't know if the whole topbar is currently displayed properly. Can you help check it? Or do you have any suggestions for solving the above problem.
Nemo157 11 days ago
Member
If you have working IPv6 then https://docs.rs.dev.nemo157.com/ is running this PR currently, looks like it's working to me.
hi-rustin 11 days ago
Author
Contributor
If you have working IPv6 then https://docs.rs.dev.nemo157.com/ is running this PR currently, looks like it's working to me.
Thanks!
hi-rustin 11 days ago
Author
Contributor
I am having problems with add-essential-files.
See: rust-lang/rustwide#41 (comment)
@jyn514 @Nemo157 Do you have any suggestions to solving this?
Show resolved
This is great, thanks!
No one assigned
None yet
No milestone
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK