Github Turn old edition lint (anonymous-parameters) into warn-by-default on 2015...

4 years ago

source link: https://github.com/rust-lang/rust/pull/82918
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Copy link

Member

Manishearth commented 25 days ago •

edited

This makes anonymous_parameters and keyword_idents warn-by-default on the 2015 edition. I would also like to do this for absolute_paths_not_starting_with_crate, but I feel that case is slightly less clear-cut.

Note that this only affects code on the 2015 edition, such code is illegal in future editions anyway.

This was spurred by dtolnay/syn#972: old edition syntax breaks tooling (like syn), and while the tooling should be free to find its balance on how much to support prior editions, it does seem like we should be nudging such code towards the newer edition, and we can do that by turning this Allow lint into a Warn.

In general, I feel like migration lints from an old edition should be made Warn after a year or so, and idiom lints for the new edition should be made Warn after a couple months.

cc @m-ou-se, this is for stuff from the 2015-2018 migration but you might be interested.

Recommend

blog.kentcdodds.com 6 years ago
Cache

JavaScript default parameters – kentcdodds

NOTE: This is a cross-post from my newsletter. I publish each email two weeks after it’s sent. Subscribe to get more content like this earlier right in your inbox! ? It’s fairly simple, but there…