4

Github Add fuget.org links to packages by drewgillies · Pull Request #8364 · NuG...

 3 years ago
source link: https://github.com/NuGet/NuGetGallery/pull/8364
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Contributor

skofman1 left a comment



@@ -163,6 +163,12 @@ public DisplayPackageViewModelFactory(IIconUrlProvider iconUrlProvider)

viewModel.ProjectUrl = projectUrl;

}

var fugetUrl = $"https://www.fuget.org/packages/{package.Id}/{package.Version}";

joelverhagen on Jan 5

Member

is this the "full version" or the "normalized version"? We should use the normalized version because that includes all URL safe characters. The build metadata is included in the full and original, non-normalized version strings. So 1.0.0+foo is a valid version but we only want 1.0.0 in the URL. To be safe, it's best to use URL encoding methods to build this URL so you don't have to think about it.

drewgillies on Jan 8

Author

Contributor

Changed it to NormalizedVersion. Thanks!


About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK