119

Add vim support. by autozimu · Pull Request #151 · autozimu/LanguageClient-neovi...

 6 years ago
source link: https://github.com/autozimu/LanguageClient-neovim/pull/151
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Add vim support. #151

Merged

autozimu merged 8 commits into

master

from

vim

on Oct 25, 2017

Merged

Add vim support. #151

autozimu merged 8 commits into

master

from

vim

on Oct 25, 2017

Conversation

Owner

@autozimu autozimu commented on Oct 24, 2017

No description provided.

Contributor

roxma commented on Oct 25, 2017

hmm...

nvim_buf_add_highlight does not exist in vim-hug-neovim-rpc

And it seems this is a neovim-only feature.

Owner

Author

autozimu commented on Oct 25, 2017

In that case, I can probably detect current feature and do not call the API for vim, which is somewhat expected. Even if I managed to get this work on vim, some of the features might never get to the state of support for neovim.

Contributor

roxma commented on Oct 25, 2017

edited

I can probably detect current feature and do not call the API for vim

I can add it into vim-hug-neovim-rpc, and it will simply ignore the error for now. I'll update the documentation for this.

This feature is hard to workaround. But it only affects the views, so ignoring the error should be just fine.

autozimu

merged commit dec2f87 into

master on Oct 25, 2017

2 checks passed

Contributor

roxma commented on Oct 26, 2017

Unfortunately I'm still having issue with completion with LanguageServer-php-neovim

screenshot_20171026_102946

screenshot_20171026_103035

These messages are forwarded from stderr of the process. But I'm not sure where it's coming from.

Owner

Author

autozimu commented on Oct 26, 2017

I cannot reproduce it.

Can you provide min vimrc and each version numbers?

Contributor

roxma commented on Oct 26, 2017

I'm debugging.

The error message forwarded by yarp is not well formatted. I'lll post detailed information when I fixed the message format.

Contributor

roxma commented on Oct 26, 2017

edited

Unfortunately, due to vim's issue on handling the python None, I workaround this issue by converting it to empty string.

vim/vim#2246

No error anymore.

Owner

Author

autozimu commented on Oct 26, 2017

+1

autozimu

deleted the vim branch

5 years ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels
None yet
Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

None yet

2 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK