2

test(metadata): Show behavior with TOML-specific types by epage · Pull Request #...

 4 weeks ago
source link: https://github.com/rust-lang/cargo/pull/13703
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

test(metadata): Show behavior with TOML-specific types #13703

Merged

Conversation

Contributor

What does this PR try to resolve?

The goal is to know if/when these change so we can have a conversation about what to do.

How should we test and review this PR?

Additional information

Collaborator

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot

added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label

Apr 4, 2024

Member

@weihanglo weihanglo

left a comment

How was this dicovered and do we have any prior discussion of it?

Contributor

Author

How was this dicovered and do we have any prior discussion of it?

I discovered it when I merged tomls functionality into toml_edit. I've previously glossed over this. In office hours, this came up for a couple of reasons

  • Caching of Cargo.toml parsing in alternative formats which could end up persisting this
  • Being prepared for a day when a cargo team member isn't maintaining toml

Contributor

@bors r+

Collaborator

📌 Commit b930f7a has been approved by arlosi

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Apr 4, 2024

Member

Being prepared for a day when a cargo team member isn't maintaining toml

I hope everything is okay 🙏🏾.

Collaborator

⌛ Testing commit b930f7a with merge a9a0746...

Contributor

Author

No announcements, more being prepared

Collaborator

☀️ Test successful - checks-actions
Approved by: arlosi
Pushing a9a0746 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

weihanglo

weihanglo left review comments
Assignees

ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

None yet

6 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK