2

rename ptr::from_exposed_addr -> ptr::with_exposed_provenance by RalfJung · P...

 4 weeks ago
source link: https://github.com/rust-lang/rust/pull/122935
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Conversation

Member

As discussed on Zulip.

The old name, from_exposed_addr, makes little sense as it's not the address that is exposed, it's the provenance. (ptr.expose_addr() stays unchanged as we haven't found a better option yet. The intended interpretation is "expose the provenance and return the address".)

The new name nicely matches ptr::without_provenance.

joboet reacted with heart emoji

Collaborator

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot

added O-hermit Operating System: Hermit O-itron Operating System: ITRON S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

labels

Mar 23, 2024

Collaborator

The Miri subtree was changed

cc @rust-lang/miri

Portable SIMD is developed in its own repository. If possible, consider making this change to rust-lang/portable-simd instead.

cc @calebzulawski, @programmerjake

RalfJung

added I-libs-api-nominated The issue / PR has been nominated for discussion during a libs-api team meeting.

and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. O-hermit Operating System: Hermit O-itron Operating System: ITRON

labels

Mar 23, 2024

This comment has been minimized.

rustbot

added O-hermit Operating System: Hermit O-itron Operating System: ITRON T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

labels

Mar 23, 2024

RalfJung

added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

and removed O-hermit Operating System: Hermit O-itron Operating System: ITRON

labels

Mar 23, 2024

rustbot

added O-hermit Operating System: Hermit O-itron Operating System: ITRON

labels

Mar 23, 2024

Collaborator

This PR changes Stable MIR

cc @oli-obk, @celinval, @ouz-a

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

This comment has been minimized.

Collaborator

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

RalfJung

added the S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). label

Mar 23, 2024

This comment has been minimized.

Collaborator

Some changes occurred to the platform-builtins intrinsics. Make sure the
LLVM backend as well as portable-simd gets adapted for the changes.

cc @antoyo, @GuillaumeGomez, @bjorn3, @calebzulawski, @programmerjake

Member

@bors r+

Contributor

📌 Commit f2cff5e has been approved by Amanieu

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label).

labels

Apr 2, 2024

bors

merged commit e9ef8e1 into

rust-lang:master

Apr 3, 2024

11 checks passed

rustbot

added this to the 1.79.0 milestone

Apr 3, 2024

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Apr 3, 2024

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Apr 3, 2024

RalfJung

deleted the with-exposed-provenance branch

April 5, 2024 16:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

Amanieu

Labels
A-strict-provenance Area: Strict provenance for raw pointers I-libs-api-nominated The issue / PR has been nominated for discussion during a libs-api team meeting. O-hermit Operating System: Hermit O-itron Operating System: ITRON S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

None yet

5 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK