1

pattern analysis: fix union handling by Nadrieril · Pull Request #123301 · rust-...

 1 month ago
source link: https://github.com/rust-lang/rust/pull/123301
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

pattern analysis: fix union handling #123301

Merged

Conversation

Contributor

Little known fact: rust supports union patterns. Exhaustiveness handles them soundly but reports nonsensical missing patterns. This PR fixes the reported patterns and documents what we're doing.

r? @compiler-errors

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Mar 31, 2024

@bors r+ rollup

Nadrieril reacted with hooray emoji

Contributor

📌 Commit 27704c7 has been approved by compiler-errors

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Apr 3, 2024

bors

merged commit 5f74403 into

rust-lang:master

Apr 3, 2024

11 checks passed

rustbot

added this to the 1.79.0 milestone

Apr 3, 2024

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Apr 3, 2024

Oneirical

added a commit to Oneirical/rust that referenced this pull request

Apr 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

compiler-errors

compiler-errors approved these changes
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

None yet

4 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK