Remove debuginfo from rustc-demangle too by Mark-Simulacrum · Pull Request #1236...
source link: https://github.com/rust-lang/rust/pull/123608
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
This is done for the same reason as the other dependencies in this list.
Collaborator
|
@Mark-Simulacrum: no appropriate reviewer found, use |
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
This comment has been minimized.
Contributor
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (a89e436): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results CyclesResults Binary sizeResults Bootstrap: 665.855s -> 667.693s (0.28%) |
removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label
Member
Author
|
r? @Kobzol perhaps? |
Member
|
r=me (I think Jakub has some vacation this week) |
Contributor
|
I think that it's fine to remove this, hopefully no one is going to debug @bors r+ (My vacation starts tomorrow 😁) |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (75fd074): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults Binary sizeResults Bootstrap: 666.9s -> 668.863s (0.29%) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK