2

Don't trigger `unused_qualifications` on global paths by jieyouxu · Pull Request...

 4 weeks ago
source link: https://github.com/rust-lang/rust/pull/122435
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Conversation

Contributor

Fixes #122374.

Collaborator

r? @michaelwoerister

rustbot has assigned @michaelwoerister.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Mar 13, 2024

This comment has been minimized.

Contributor

In regards to the linked issue, Default is already included in the prelude so technically the full path is indeed unnecessary.

cc @petrochenkov since you are involved in #121708

In regards to the linked issue, Default is already included in the prelude so technically the full path is indeed unnecessary.

There seems to be a diagnostics design/policy question involved here.

r? diagnostics

This comment was marked as resolved.

r? petrochenkov

Contributor

This change makes behavior of unused_qualifications more conservative and closer to its previous version, thus addressing some false positives from incorrectly written proc macros.
@bors r+

Contributor

📌 Commit 85bad8d has been approved by petrochenkov

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Mar 19, 2024

bors

merged commit 489c2e9 into

rust-lang:master

Mar 19, 2024

11 checks passed

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Mar 19, 2024

jieyouxu

deleted the unused_qualifications_global_paths branch

March 19, 2024 20:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

unused_qualifications warns about global paths

8 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK