Let codegen decide when to `mem::swap` with immediates by scottmcm · Pull Reques...

This comment has been minimized.

marked this pull request as draft

March 16, 2024 05:45

added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

marked this pull request as ready for review

March 16, 2024 09:23

Collaborator

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

The Miri subtree was changed

cc @rust-lang/miri

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Member

Author

This comment has been minimized.

Contributor

⌛ Trying commit e583c57 with merge 3f68c63...

Contributor

☀️ Try build successful - checks-actions
Build commit: 3f68c63 (3f68c63f114f4d57b01ae74bc549e4b68f955eee)

This comment has been minimized.

This comment was marked as outdated.

rustbot

added perf-regression Performance regressions

and removed S-waiting-on-perf Status: Waiting on a perf run to be completed.

labels

library/core/src/ptr/mod.rs

Outdated

		@@ -954,6 +954,23 @@ pub const unsafe fn swap<T>(x: mut T, y: mut T) {
		}
		}

		/// Non-overlapping typed swap of a single value.

Should it be called typed_swap_nonoverlapping?

Member

Author

I went back and forth multiple times on this. typed_swap_nonoverlapping sounds to me like ptr::swap_nonoverlapping, just typed. So that would make this typed_swap_nonoverlapping_one or something, and now that's just seeming really long.

So since it's internal, I think I'm inclined to leave it as-is for now unless someone feels particularly strongly about it.

I feel like the "nonoverlapping" distinction is way more fundamental than the "one" distinction. And since it is internal, consistency with ptr::swap_nonoverlapping isn't very important IMO.

This comment has been minimized.

Contributor

💔 Test failed - checks-actions

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Member

Author

@bors r=oli-obk

Contributor

📌 Commit 75d2e5b has been approved by oli-obk

It is now in the queue for this repository.

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Contributor

⌛ Testing commit 75d2e5b with merge ea4d0e9044c417ec9df5b45620f316879fd179c2...

Contributor

💥 Test timed out

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Member

@bors retry

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels