1

Strip placeholders from hidden types before remapping generic parameter by oli-o...

 4 weeks ago
source link: https://github.com/rust-lang/rust/pull/122733
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Conversation

Contributor

When remapping generic parameters in the hidden type to the generic parameters of the definition of the opaque, we assume that placeholders cannot exist. Instead of just patching that site, I decided to handle it earlier, directly in infer_opaque_types, where we are already doing all the careful lifetime handling.

fixes #122694

the reason that ICE now occurred was that we stopped treating operation as being in the defining scope, so the TAIT became part of the hidden type of the async fn's opaque type instead of just bailing out as ambiguos

I think

use std::future::Future;

mod foo {
    type FutNothing<'a> = impl 'a + Future<Output = ()>;
    //~^ ERROR: unconstrained opaque type
}

async fn operation(_: &mut ()) -> () {
    //~^ ERROR: concrete type differs from previous
    call(operation).await
    //~^ ERROR: concrete type differs from previous
}

async fn call<F>(_f: F)
where
    for<'any> F: FnMut(&'any mut ()) -> foo::FutNothing<'any>,
{
    //~^ ERROR: expected generic lifetime parameter, found `'any`
}

would have already had the same ICE before #121796


report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK