fix(alias): dont panic when resolving an empty alias by weihanglo · Pull Request...
source link: https://github.com/rust-lang/cargo/pull/13613
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
fix(alias): dont panic when resolving an empty alias #13613
Conversation
Member
What does this PR try to resolve?
Previously Cargo panicked when resolving empty aliases like these:
[alias]
buidthis = ""
buildthat = []This PR fixes it.
How should we test and review this PR?
The first commit with a test demonstrates the panic, followed by a commit fixing that.
added A-cli Area: Command-line interface, option parsing, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
|
@bors r+ |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Collaborator
|
☀️ Test successful - checks-actions |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
None yet
No milestone
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK