4

Tracking Issue for `proc_macro_c_str_literals` · Issue #119750 · rust-lang/rust...

 1 month ago
source link: https://github.com/rust-lang/rust/issues/119750
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Tracking Issue for proc_macro_c_str_literals #119750

2 of 4 tasks

novafacing opened this issue Jan 8, 2024 · 4 comments

2 of 4 tasks

Comments

Contributor

novafacing

commented

Jan 8, 2024

edited by dtolnay

Feature gate: #![feature(proc_macro_c_str_literals)]

This is a tracking issue for C String literals in proc macros under #105723 and #118560, with an implementation in #119651.

This feature adds an API to construct a proc_macro::Literal C string directly.

Public API

let lit: Literal = Literal::c_string(&CString::new("Hello, world!").unwrap());

Steps / History

Unresolved Questions

MaxVerevkin reacted with thumbs up emoji

Contributor

Author

c_str_literals have been re-stabilized, I think this can now be considered for stabilization.

Member

@rust-lang/libs-api:
@rfcbot fcp merge

Literal::c_string(&CString::new("Hello, world!").unwrap()) constructs the literal c"Hello, world!".

C-string literals stabilized recently in Rust 1.77.

rfcbot

commented

Mar 24, 2024

edited by m-ou-se

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot

added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised.

and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.

labels

Mar 24, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Assignees

No one assigned

Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

No milestone

Development

No branches or pull requests

3 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK