0

Fix bad span for explicit lifetime suggestions by ShoyuVanilla · Pull Request #1...

 4 weeks ago
source link: https://github.com/rust-lang/rust/pull/121587
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Conversation

Contributor

Fixes #121267

Current explicit lifetime suggestions are not showing correct spans for some lifetimes - e.g. elided lifetime generic parameters;

This should be done correctly regarding elided lifetime kind like the following code

estebank reacted with heart emoji

Collaborator

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

labels

Feb 25, 2024

Contributor

@estebank estebank

left a comment

Please squash your three commits into one.

ShoyuVanilla reacted with thumbs up emoji

Contributor

Author

Please squash your three commits into one.

Thanks! I've squash rebased onto the recent revision 😄

Member

@bors r+

Contributor

📌 Commit c270a42 has been approved by TaKO8Ki

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Mar 21, 2024

Contributor

⌛ Testing commit c270a42 with merge 6e1f7b5...

Contributor

☀️ Test successful - checks-actions
Approved by: TaKO8Ki
Pushing 6e1f7b5 to master...

bors

added the merged-by-bors This PR was explicitly merged by bors label

Mar 21, 2024

bors

merged commit 6e1f7b5 into

rust-lang:master

Mar 21, 2024

12 checks passed

Collaborator

Finished benchmarking commit (6e1f7b5): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.782s -> 669.528s (-0.04%)
Artifact size: 312.72 MiB -> 312.72 MiB (-0.00%)

ShoyuVanilla

deleted the fix-issue-121267 branch

March 21, 2024 08:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

TaKO8Ki

Awaiting requested review from TaKO8Ki

estebank

Awaiting requested review from estebank
Assignees

TaKO8Ki

Labels
merged-by-bors This PR was explicitly merged by bors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

The output help is incorrect, lifetime appears in an unexpected position

6 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK