Inherit `RUSTC_BOOTSTRAP` when testing wasm by alexcrichton · Pull Request #1227...
source link: https://github.com/rust-lang/rust/pull/122795
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Member
This is implemented with the freshly-released Wasmtime 19 and should prevent beta breakage from wasm tests that was observed and fixed in #122640 again.
Collaborator
|
rustbot has assigned @albertlarsan68. Use |
added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
labels
Member
Author
|
I'll note here as well that this PR is inspired by this thread |
|
@bors r+ Thanks! I ended up not landing the forward port (forgot) so I think we can just move ahead with this presuming it works :) |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
// NB: with Wasmtime 20 this can change to `-S inherit-env` to |
||
// inherit the entire environment rather than just this single |
||
// environment variable. |
||
path.push_str(" --env RUSTC_BOOTSTRAP"); |
Contributor
This variable's name is a bit unfortunate, maybe something like command?
True! If this bounces I'll refactor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK