Move `--sysroot` argument out of the argument file to fix miri issue by Guillaum...
source link: https://github.com/rust-lang/rust/pull/123030
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Fixes rust-lang/miri#3404.
For now, miri needs this argument to be moved out of the arg file so they can update it if needed.
cc @RalfJung
r? @notriddle
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Member
|
Thanks a lot! Yes I hope this will resolve the Miri issue. |
Contributor
|
@bors r+ |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Member
|
@bors p=1 |
Contributor
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (cb7c636): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results CyclesResults Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 672.431s -> 670.74s (-0.25%) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
None yet
Successfully merging this pull request may close these issues.
cargo miri test is broken for doctests (Option 'sysroot' given more than once)
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK