4

Include Retry Button in Drag/Click Screenshot Capture Options

 3 months ago
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1873882
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Closed Bug 1873882 Opened 1 month ago Closed 1 month ago

Include Retry Button in Drag/Click Screenshot Capture Options

Categories

(Firefox :: Screenshots, enhancement, P3)

Tracking

(bug has been fixed and VERIFIED)

VERIFIED FIXED

123 Branch

Tracking Status
firefox123 --- verified

People

(Reporter: sbadau, Assigned: niklas)

References

(Blocks 1 open bug)

Details

Found in

  • Nighty 123.0a1

Affected versions

  • Nighty 123.0a1

Tested platforms

  • Affected platforms: macOS 13, Ubuntu 22.04 and Windows 10 x64.

Preconditions

  • 'screenshots.browser.component.enabled' is set to true in about:config

Steps to reproduce

  1. Enable Screenshots by hitting the Cmd/Ctrl+Shift+S keys.
  2. Select a region by mouse dragging over the screenshots overlay.
  3. Observe the available buttons.

Expected result

  • The buttons provided when capturing a screenshot by drag or click should be consistent with the options provided by "Save visible" or "Save full page."

Actual result

  • The Retry button is not present when capturing a screenshot by drag or click.

Regression range

  • This is not a regression.

We think maybe the "X" icon in the overlay toolbar should actually restore the "Drag or click on the page" (crosshairs) state rather than close the screenshots UI entirely.

Assignee: nobody → nbaumgardner
No longer blocks: 1789727
Status: NEW → ASSIGNED
Priority: -- → P3
Attachment #9372644 - Attachment description: WIP: Bug 1873882 - Canceling screenshots selected state should go to crosshairs state. r=sfoster → Bug 1873882 - Canceling screenshots selected state should go to crosshairs state. r=sfoster

I can confirm that when when clicking the "X" button in the overlay toolbar - Screenshots is not dismissed but a Retry is done - tested using the latest Nightly 123.0a2 (build ID: 20240117145030) on Windows 10 x64, Ubuntu 22.04 and macOS 13.

@Sam, with this change the "X" button in the overlay toolbar has a different functionality than the "X" button in the Save dialogs. Are there any upcoming plans to update the button label to "Retry," or will it will remain as is?

Flags: needinfo?(sfoster)

(In reply to Simona Badau, Desktop QA from comment #5)

@Sam, with this change the "X" button in the overlay toolbar has a different functionality than the "X" button in the Save dialogs. Are there any upcoming plans to update the button label to "Retry," or will it will remain as is?

I'm thinking of this more like an undo stack. Close or Escape puts you back to the previous state when you made a choice. I'm not sure if other people will understand this the same way, but for now, no plans to update the button label.

Flags: needinfo?(sfoster)

(In reply to Sam Foster [:sfoster] (he/him) from comment #6)

(In reply to Simona Badau, Desktop QA from comment #5)

@Sam, with this change the "X" button in the overlay toolbar has a different functionality than the "X" button in the Save dialogs. Are there any upcoming plans to update the button label to "Retry," or will it will remain as is?

I'm thinking of this more like an undo stack. Close or Escape puts you back to the previous state when you made a choice. I'm not sure if other people will understand this the same way, but for now, no plans to update the button label.

Thanks, Sam!

Based on this marking this as Verified Fixed!

You need to log in before you can comment on or make changes to this bug.

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK